Did Smith correctly state the mass formula?

H.J.S. "normal form" Smith was the first, in 1867, to state the mass formula for integral quadratic forms in a genus of 4 or more variables. This was forgotten and the formula is usually attributed to Minkowski, who rediscovered it in 1885, and to Siegel, who corrected Minkowski in 1935. Conway and Sloane mention a number of erroneous sources after Siegel, but though they quote Smith worrying that he has made an error, they mention no errror, suggesting that he got it right. On the other hand, they say that in addition to the 1867 paper, Smith had an 1884 paper which won a prize from the French Academy jointly with Minkowski. So I expect that the judges compared the two results and would have noticed a discrepancy, suggesting that they were equally right or wrong.

I'm not sure what any of these papers actually state. The 1884 competition was about the specific case of the sum of five squares, so perhaps the entries imposed restrictions that saved their correctness and Minkowski's error was only in the 1885 extension? In particular, I think that he restricted to odd forms in 1884, but I forget my source for this. Conway and Sloane say that Smith's 1867 formula restricted to odd determinant.

More generally, what are good sources for the history of quadratic forms?